Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix to overflow box 8E on the 0781a form generated by the 526 flow #19667

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

kylesoskin
Copy link
Contributor

@kylesoskin kylesoskin commented Dec 2, 2024

Previously (or currently I guess) box 8E on 0781a's generated from the 526 flow, does not have overflow set.

This results in all the characters, no matter how many, being put in the box. While all data is technically there, after a number of chars, it exceeds the space in the box and becomes overlapped by the rest of the form, and not visible to adjudicators.

Box 8E in the 0781 is set to 268 chars , depending on the chars, I have been able to fit up to 275 in the box, so 268 is probably max, minus a safe buffer.

Box 8E on the 0781a, is bigger. And can fit roughly double the amount of chars. I am prosing setting box 8E on the 0781a to exactly double what the 0781 smaller box is set to, so 536 chars

Screenshot 2024-12-02 at 10 15 20 AM

Related ticket: department-of-veterans-affairs/va.gov-team#93519

Testing done:

Locally, submit with no limit set, no overflow happens, error is seen.
Locally, submit with 536 chars, it displays correctly and fits in the form box.
Locally, submit with 537 chars, it correctly overflows and instructs to see additional page in the form box.

@kylesoskin kylesoskin marked this pull request as ready for review December 2, 2024 16:39
@kylesoskin kylesoskin requested review from a team as code owners December 2, 2024 16:39
@kylesoskin kylesoskin enabled auto-merge (squash) December 2, 2024 16:39
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kylesoskin kylesoskin merged commit 19f746a into master Dec 2, 2024
63 of 64 checks passed
@kylesoskin kylesoskin deleted the ksoskin/90781a_bugfix branch December 2, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants